Enabling RCCL and GEMM sweep test on GH action #55
Conversation
|
Sample for Gemm Sweep CI : Run Sample Run with aorta-report checkin : |
| paths: | ||
| - 'scripts/gemm_analysis/**' | ||
| - 'config/gemm_overlap/**' | ||
| #pull_request: |
There was a problem hiding this comment.
if this code is not required, then please delete these lines.
There was a problem hiding this comment.
We are keeping this for now as we are still testing the yml locally, and in near future we may need to do this testing. But in production, we do not want to kick in this yml for every PR. Hence commented. Code is there for local testing on branch, but not enable for production.
| gemm-sweep: | ||
| name: Run GEMM Sweep Profiling | ||
| runs-on: [self-hosted, gpu, rocm] | ||
| runs-on: self-hosted |
There was a problem hiding this comment.
I hope you are not planning to keep the self-hosted in the final merge. Please change it to the runner machine name once you get it.
There was a problem hiding this comment.
For now, I am keeping this self-hosted as we have not got the runner.
| working-directory: docker | ||
| working-directory: aorta | ||
| run: | | ||
| #mkdir -p ~/.docker/cli-plugins |
docker/rccl_test/docker-compose.yaml
Outdated
|
|
||
| volumes: | ||
| - /home/manrao:/manrao | ||
| - /home/oyazdanb/aorta:/workspace/aorta |
There was a problem hiding this comment.
is it correct? why are we mapping Sonbol's area?
There was a problem hiding this comment.
This file is not used, later we should remove this file.
prosenjitdhole
changed the title
| path: aorta/${{ env.SWEEP_DIR }}/ | ||
| retention-days: 90 | ||
| git config user.name "GitHub Actions Bot" | ||
| git config user.email "<>" |
There was a problem hiding this comment.
is it allowed to keep email empty and still able to push to github?
There was a problem hiding this comment.
it is working .. And thats how we are doing it in other shark test suites.
| working-directory: aorta-report | ||
| run: | | ||
| git config user.name "GitHub Actions Bot" | ||
| git config user.email "<>" |
amd-vivekag
left a comment
amd-vivekag
left a comment
There was a problem hiding this comment.
Approved. Some comments and TODOs are pending which can be resolved in next PR
This is a temporary change to install local amd gpu installation instead of fetching it from amd cdn